Skip to content

Delete wrong/oudated note #4486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Delete wrong/oudated note #4486

merged 1 commit into from
Jul 22, 2020

Conversation

Youssef1313
Copy link
Member

@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 8, 2020
@gewarren gewarren requested a review from a team July 21, 2020 18:38
wfurt
wfurt approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems like close/Dispose on the client will dispose underlying stream if it exists.

@gewarren gewarren merged commit f544d12 into dotnet:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

Outdated note?
4 participants
@Youssef1313 @wfurt @dotnet-bot @gewarren